Naitik Shah
|
bb439ce0e5
|
Merge pull request #6 from rubyist/master
Unexpected client disconnections can cause a panic and crash the server
|
2013-11-04 08:50:03 -08:00 |
|
rubyist
|
906a8cad55
|
Move defer outside the closure
|
2013-11-04 06:57:07 -05:00 |
|
rubyist
|
43ccb346c3
|
defer the Done() call
|
2013-11-03 13:47:47 -05:00 |
|
rubyist
|
c846d177f2
|
make conn a pointer again
|
2013-11-03 13:41:56 -05:00 |
|
rubyist
|
1d3eeaacf9
|
Use sync.Once instead of bool flag
|
2013-11-03 13:22:18 -05:00 |
|
rubyist
|
e068b65c78
|
Ensure that the WaitGroup isn't marked done twice when edgecase errors occurr
|
2013-11-03 13:03:01 -05:00 |
|
Naitik Shah
|
d2b7f5f03a
|
sigh. add sleep for now to avoid connection reset by peer issues
|
2013-10-24 15:22:03 -07:00 |
|
Naitik Shah
|
4636466d77
|
grace.Process for more options and control
|
2013-10-24 13:15:29 -07:00 |
|
Naitik Shah
|
e79c66960f
|
doc nit
|
2013-10-24 12:33:05 -07:00 |
|
Naitik Shah
|
9aca7f00c4
|
stop signals before we start the graceful stop process
|
2013-10-15 11:55:48 -07:00 |
|
Naitik Shah
|
d1f693d1d4
|
refactor gracehttp for readability
|
2013-10-15 11:54:28 -07:00 |
|
Naitik Shah
|
aad68df4be
|
stop signals once initial term has been processed. fixes #5
|
2013-10-15 10:50:08 -07:00 |
|
Naitik Shah
|
211c8342b3
|
use time.Now for timeInPast
|
2013-10-07 22:57:59 -07:00 |
|
Naitik Shah
|
60b34bd164
|
comments
|
2013-10-06 13:01:58 -07:00 |
|
Naitik Shah
|
f5295e5b81
|
use defer for wg.Done to ensure its called
|
2013-10-06 12:19:25 -07:00 |
|
Naitik Shah
|
ae3f6c71a7
|
remove old env variable on restart
|
2013-10-06 12:14:11 -07:00 |
|
Naitik Shah
|
c0e92551f5
|
wtf append nil?
|
2013-10-06 11:33:37 -07:00 |
|
Naitik Shah
|
f2bbd9297e
|
dont need to be TCP specific
|
2013-10-06 11:25:24 -07:00 |
|
Naitik Shah
|
09bc4c424a
|
dont throw away SetDeadline error
|
2013-10-06 11:07:31 -07:00 |
|
Naitik Shah
|
70bbce6ad2
|
dont use named return variables in a strange way
|
2013-10-06 11:05:27 -07:00 |
|
Naitik Shah
|
61aafa98f8
|
move inline interface out for readability
|
2013-10-06 11:00:22 -07:00 |
|
Naitik Shah
|
220ebb1f4f
|
use defer in conn.Close
|
2013-10-06 10:54:16 -07:00 |
|
Naitik Shah
|
e3a666a3f1
|
more testing and resiliency
|
2013-10-06 10:38:28 -07:00 |
|
Naitik Shah
|
d69b13103f
|
wait after stop
|
2013-10-06 10:01:17 -07:00 |
|
Naitik Shah
|
9a444d2674
|
move build out for shared builds
|
2013-10-06 09:58:50 -07:00 |
|
Naitik Shah
|
e2cfa20d82
|
add apache 2.0 license. closes #4
|
2013-10-01 09:54:56 -07:00 |
|
Naitik Shah
|
72ccd60490
|
fix bugs pointed out by go vet
|
2013-09-18 17:58:04 -07:00 |
|
Naitik Shah
|
f41bb0a2be
|
handle race condition that may arise between accept and add
|
2013-09-10 12:42:11 -07:00 |
|
Naitik Shah
|
4817bd8812
|
mention TLS
|
2013-08-31 19:59:33 -07:00 |
|
Naitik Shah
|
e39d448b5c
|
use godoc instead of gowalker
|
2013-08-21 12:29:34 -07:00 |
|
Naitik Shah
|
ebaf0674d2
|
spelling nit
|
2013-08-20 16:48:43 -07:00 |
|
Naitik Shah
|
57754541e7
|
dont drop the last connection. fixes TLS issues
|
2013-08-20 16:23:38 -07:00 |
|
Naitik Shah
|
267d243f26
|
ensure correct pid when waiting for server
|
2013-08-20 13:28:03 -07:00 |
|
Naitik Shah
|
eb6bada57c
|
connection refused errors are expectede
|
2013-08-20 13:15:00 -07:00 |
|
Naitik Shah
|
8060336110
|
https support in gracehttp
|
2013-08-20 11:38:19 -07:00 |
|
Naitik Shah
|
8711fea1ad
|
remove last sleep in test path
|
2013-08-19 23:12:26 -07:00 |
|
Naitik Shah
|
a4481adb67
|
remove most unnecessary sleeps from tests
|
2013-08-19 22:51:32 -07:00 |
|
Naitik Shah
|
2024e37361
|
flag for debug logging rather than const
|
2013-08-19 15:39:03 -07:00 |
|
Naitik Shah
|
0b607a2494
|
mutex for h.Process mutation to prevent data races
|
2013-08-19 15:37:41 -07:00 |
|
Naitik Shah
|
3bfe2f78ad
|
use gowalker instead of godoc
|
2013-05-18 10:47:59 -07:00 |
|
Naitik Shah
|
40f23f4b6f
|
readme nit
|
2013-05-18 10:31:19 -07:00 |
|
Naitik Shah
|
792bc8817c
|
replace gracehttp.Handler with http.Server for maximum control
this is a backward incompatible change as such. http.Server is a
superset of what gracehttp.Handler was and the fix is trivial.
|
2013-05-09 09:28:09 -07:00 |
|
Naitik Shah
|
6bda16a267
|
fix racy behavior with closing channels
replaces custom channel logic with simpler RWMutex and WaitGroup
|
2013-05-08 23:25:58 -07:00 |
|
Naitik Shah
|
8f7f9df910
|
drop connections that come in between a close and an accept race
this is bad, but worse is the current logic which can sometimes hit a
nil counter channel.
|
2013-04-03 18:11:40 -07:00 |
|
Naitik Shah
|
249c1519e3
|
needed for go 1.0.x
|
2013-03-27 19:36:19 -07:00 |
|
Naitik Shah
|
d710f745bd
|
also close the counter channel to raise potential data races
|
2013-03-27 18:43:33 -07:00 |
|
Naitik Shah
|
40271cd1a7
|
fix data races around use of l.closed
fixes #1
|
2013-03-27 18:29:36 -07:00 |
|
Naitik Shah
|
3efb5417dc
|
readme explaining gracedemo usage
|
2013-03-25 19:21:14 -07:00 |
|
Naitik Shah
|
95348749e8
|
incorrect demo comment
|
2013-03-25 16:37:01 -07:00 |
|
Naitik Shah
|
e6c599461d
|
return on error
|
2013-03-25 14:59:40 -07:00 |
|